Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Challenge submission by Chris Harper #12

Merged
merged 2 commits into from Jul 28, 2022

Conversation

chrisharper22
Copy link
Contributor

My submission for the first challenge.

It has the visualizer and the ability to change the color (as well as resetting it to Spotify's green). Also showcases a little remake of the List/Form views.

Screen.Recording.2022-07-21.at.11.45.08.PM.mov

@DaemonLoki
Copy link
Contributor

Hey @chrisharper22!

I love the fact, that you allow the option to experiment with other colors, that's a great idea! :)

Also, I really like the structure of the code, to have parts of the UI as properties. Feel very apple-y. :)
Any strategy you have there? I'm always unsure of when to use properties vs. just putting it in a custom view.

Thanks in any case for your submission. Want an extra challenge? :)

Best,
Stefan

@chrisharper22
Copy link
Contributor Author

Hi @DaemonLoki

For the subview properties vs. standalone views, it depends on the context of the views. If I plan on reusing them, then I'll make them their own struct.

What's the extra challenge you're speaking of?

And of course! The idea of SwiftUI challenges is great. Love the idea of having a goal that everyone can experiment with.

:)

Chris

@amosgyamfi
Copy link
Collaborator

I like the ability to change the colors. You also used the right easing for the animation.

@DaemonLoki DaemonLoki merged commit e791600 into SwiftUI-Animation-Challenges:main Jul 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants