Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix so that Rule can be subclassed #177

Closed
wants to merge 1 commit into from

Conversation

jspenc72
Copy link

Swift 3 is adding 2 more access levels (open and fileprivate) and changing the meaning of private:

private: symbol visible within the current declaration only.
fileprivate: symbol visible within the current file.
internal: symbol visible within the current module.
public: symbol visible outside the current module.
open: for class or function to be subclassed or overridden outside the current module.

In Swift 3 you can now mark a class as open instead of public this allows files outside of the module to subclass that class.

Swift 3 is adding 2 more access levels (open and fileprivate) and changing the meaning of private:

private: symbol visible within the current declaration only.
fileprivate: symbol visible within the current file.
internal: symbol visible within the current module.
public: symbol visible outside the current module.
open: for class or function to be subclassed or overridden outside the current module.

In Swift 3 you can now mark a class as open instead of public this allows files outside of the module to subclass that class.
@codecov-io
Copy link

Codecov Report

Merging #177 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #177   +/-   ##
=======================================
  Coverage   80.82%   80.82%           
=======================================
  Files          26       26           
  Lines         485      485           
=======================================
  Hits          392      392           
  Misses         93       93
Impacted Files Coverage Δ
SwiftValidator/Rules/RegexRule.swift 100% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2a6c23a...8da602c. Read the comment docs.

@jpotts18
Copy link
Collaborator

jpotts18 commented Jul 9, 2017

Sorry for the delay @jspenc72 I don't do Swift in my day-to-day and this project is suffering. Would you be interested in becoming a contributor?

@jspenc72
Copy link
Author

jspenc72 commented Jul 10, 2017 via email

@jpotts18
Copy link
Collaborator

@jspenc72 I"ve added you as a contributor can you please merge these changes and make sure any necessary documentation and tests are added that prove the functionality changes. Still learning about permissions on organization so let me know if you see any hiccups

@jspenc72
Copy link
Author

Ill have a look tonight and get things merged in.

@davepatterson
Copy link
Member

@jspenc72 This was addressed in #175

@jspenc72
Copy link
Author

jspenc72 commented Jul 16, 2017 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants