Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add an extension to create a MD5 hash from a string #338

Closed
JulianYu opened this issue Dec 13, 2017 · 5 comments
Closed

Add an extension to create a MD5 hash from a string #338

JulianYu opened this issue Dec 13, 2017 · 5 comments

Comments

@JulianYu
Copy link

@JulianYu JulianYu commented Dec 13, 2017

[ ] I've read, understood, and done my best to follow the Contributing guidelines before opening this issue.

What did you expect to happen?

how about add something like md5

@omaralbeik

This comment has been minimized.

Copy link
Member

@omaralbeik omaralbeik commented Dec 13, 2017

@JulianYu, thats a nice extension to have, could you please submit a pull request and I'll make sure to review it and get it merged in as soon as I can 👍

@omaralbeik omaralbeik changed the title Md5 string Add an extension to create a MD5 hash from a string Dec 13, 2017
@omaralbeik

This comment has been minimized.

Copy link
Member

@omaralbeik omaralbeik commented Dec 13, 2017

I found this stackoverflow thread that has a suggested way of doing this.

@SD10

This comment has been minimized.

Copy link
Member

@SD10 SD10 commented Dec 20, 2017

@omaralbeik What do you think about this? SwifterSwift has very little to no limitations when it comes to which extensions we accept into the project, but I think avoiding adding cryptography extensions is a healthy limitation.

@omaralbeik

This comment has been minimized.

Copy link
Member

@omaralbeik omaralbeik commented Dec 20, 2017

@SD10 I agree. let's not get into cryptography for now

@omaralbeik

This comment has been minimized.

Copy link
Member

@omaralbeik omaralbeik commented Dec 20, 2017

@JulianYu Thank you for bringing this to the table. We don't think SwifterSwift is a good fit for cryptography extensions at the moment, CryptoSwift is taking care of this :)

@omaralbeik omaralbeik closed this Dec 20, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.