Add support for custom foreground image color and custom blur effects #21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
From what I understand, the big conversion to Swift of
SVProgressHUDwas done around November 2018.I was thinking to go through new additions to
SVProgressHUDin chronological order and port them over toIHProgressHUD.Here I started with this commit from Jan 23, 2019 which adds the option to have a custom blur effect even with a custom text or image color and adds the option to set a custom color only for image or loading indicator ring while keeping the default text color inside the progress hud.
I successfully tested it manually.
It would be nice to add options to test the above in the Example app but I noticed that UI is all done with individual auto layout constraints for each view. It would be much easier to use stack views where we could easily drop in new controls as more features are added.
That feels like a bigger separate PR and I wanted to start small.