json.url method returned url encoded the '#'

[CasparZheng]

What did you do?

let jsonObj = JSON.init(rawValue: "https://store.insta360.com/accessory#commodity")
let commonUrl = jsonObj.url
print(commonUrl)

What did you expect to happen?

//print result:
https://store.insta360.com/accessory#commodity

What actually happened instead?

returned result encode the '#' to '%23', '#' is a keyword in url semantic, it means tag. it should not be encoded.

//print result:
https://store.insta360.com/accessory%23commodity

Environment

List the software versions you're using:

• SwiftyJSON: 4.1.0
• Xcode Version: 9.3 (9E145) (Open Xcode; In menubar: Xcode > About Xcode)
• Swift Version: Xcode Default (Open Xcode Preferences; Components > Toolchains. If none, use Xcode Default.)

Please also mention which package manager you used and its version. Delete the
other package managers in this list:

• Carthage: 0.29.0 (Use carthage version in Terminal)

Project that demonstrates the issue

Please link to a project we can download that reproduces the issue. Feel free
to delete this section if it's not relevant to the issue (eg - feature request).

The project should be short, self-contained, and correct example.

just test the url : "https://store.insta360.com/accessory#commodity", if encode to "https://store.insta360.com/accessory%23commodity" will get 404 in http protocol

[anton-plebanovich]

Have the same issue. Query escaping encoding shouldn't be applied to whole URL and instead to query only. Probably it should support all available encodings: urlUserAllowed urlPasswordAllowed urlHostAllowed urlPathAllowed urlQueryAllowed urlFragmentAllowed. Or at least some of them.