Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: fix actor isolation bug with protocol conformance on older swift versions #11

Merged
merged 2 commits into from
Dec 15, 2022

Conversation

soumyamahunt
Copy link
Contributor

No description provided.

@codecov
Copy link

codecov bot commented Dec 14, 2022

Codecov Report

Base: 99.90% // Head: 97.83% // Decreases project coverage by -2.06% ⚠️

Coverage data is based on head (157567c) compared to base (bca8299).
Patch coverage: 96.87% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #11      +/-   ##
==========================================
- Coverage   99.90%   97.83%   -2.07%     
==========================================
  Files          13       20       +7     
  Lines        1054     1666     +612     
==========================================
+ Hits         1053     1630     +577     
- Misses          1       36      +35     
Impacted Files Coverage Δ
...ources/AsyncObjects/Continuation/Continuable.swift 90.90% <90.90%> (ø)
Sources/AsyncObjects/AsyncSemaphore.swift 93.75% <92.18%> (-6.25%) ⬇️
Sources/AsyncObjects/AsyncEvent.swift 93.58% <92.30%> (-6.42%) ⬇️
Sources/AsyncObjects/AsyncCountdownEvent.swift 94.81% <93.57%> (-5.19%) ⬇️
Sources/AsyncObjects/TaskOperation.swift 96.96% <94.04%> (-3.04%) ⬇️
Sources/AsyncObjects/TaskQueue.swift 98.18% <96.52%> (-1.82%) ⬇️
...syncObjects/Continuation/TrackedContinuation.swift 96.66% <96.66%> (ø)
Sources/AsyncObjects/Future.swift 98.73% <97.72%> (-1.27%) ⬇️
Sources/AsyncObjects/Base/AsyncObject+Clock.swift 100.00% <100.00%> (ø)
...urces/AsyncObjects/Base/AsyncObject+Duration.swift 100.00% <100.00%> (ø)
... and 15 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@sonarcloud
Copy link

sonarcloud bot commented Dec 15, 2022

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
37.0% 37.0% Duplication

@soumyamahunt soumyamahunt merged commit c1ce0e2 into main Dec 15, 2022
@soumyamahunt soumyamahunt deleted the isolation-fix branch December 15, 2022 08:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant