fix: @Codable fails in structs with static members. #37
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
soumyamahunt
requested changes
Nov 6, 2023
Sources/CodableMacroPlugin/Attributes/RegistrationAttribute.swift
Outdated
Show resolved
Hide resolved
Sources/CodableMacroPlugin/Attributes/RegistrationAttribute.swift
Outdated
Show resolved
Hide resolved
soumyamahunt
requested changes
Nov 6, 2023
Sources/CodableMacroPlugin/Attributes/RegistrationAttribute.swift
Outdated
Show resolved
Hide resolved
Midbin
force-pushed
the
StaticFields
branch
2 times, most recently
from
c5af16a
to
209a4b4
Compare
soumyamahunt
reviewed
Nov 6, 2023
Sources/CodableMacroPlugin/Diagnostics/StaticVariableDeclaration.swift
Outdated
Show resolved
Hide resolved
soumyamahunt
reviewed
Nov 6, 2023
Sources/CodableMacroPlugin/Diagnostics/StaticVariableDeclaration.swift
Outdated
Show resolved
Hide resolved
|
@Midbin please run swift-format as well: swift run swift-format --in-place --ignore-unparsable-files --recursive Sources Tests |
soumyamahunt
approved these changes
Nov 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #26.
Please note that I ran into, what I think, is a small swift compiler bug.
My workaround is in
RegistrationAttribut.swift:45-52andStaticVariableDeclaration.swift:46-50.This is based on #34 because it also adds new tests and I will rebase this PR when #34 lands.