Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suggestions for return_random_participants #151

Closed
DrEspresso opened this issue Jan 7, 2020 · 1 comment · Fixed by #178
Closed

Suggestions for return_random_participants #151

DrEspresso opened this issue Jan 7, 2020 · 1 comment · Fixed by #178
Assignees
Labels
documentation tasks regarding documentation of the package enhancement New feature or request

Comments

@DrEspresso
Copy link
Contributor

Is your feature request related to a problem? Please describe.
The function does not check whether a centre in centers exists.
The function does not accept percent=1 (maybe useful for consistency checks)
The help page does not explain how the percentage of participants is rounded to integers.

Describe the solution you'd like
A warning should be shown if an element of centers is not an element of ...$ctr

The allowed range of values for percent should include 0 and 1.

The help page should be extended.
There is also one typo:

percantage

@PatrickRWright
Copy link
Collaborator

@DrEspresso it would be good to have this implemented by late February just to give a timeline. Can you do that?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation tasks regarding documentation of the package enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants