Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

factorization of variables in lookuptables seems to be broken #224

Closed
PatrickRWright opened this issue Nov 3, 2020 · 1 comment · Fixed by #232
Closed

factorization of variables in lookuptables seems to be broken #224

PatrickRWright opened this issue Nov 3, 2020 · 1 comment · Fixed by #232
Assignees
@aghaynes @PatrickRWright

Comments

@PatrickRWright
Copy link
Collaborator

Describe the bug
Factor variables in lookuptables are not factorized anymore by factorize_secuTrial(). This probably happened during the implementation of the speedup in version 1.0.4. The silent fail can likely be attributed to no export with lookups being available for testing.

To Reproduce
Read an export with lookups and factorize it. Check the variables from the lookup tables.

Expected behavior
Factorization like usual.

Additional context
We need an example export with lookup tables too so this can be covered by tests in future.
@PatrickRWright
Copy link
Collaborator Author

@PatrickRWright needs to prepare an database which includes a lookuptable data structure so that we can properly fix this and cover it with tests.

@PatrickRWright PatrickRWright mentioned this issue Dec 4, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@aghaynes aghaynes

@PatrickRWright PatrickRWright

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

factorization of categorical variables in lookuptables
2 participants
@aghaynes @PatrickRWright