Skip to content
This repository has been archived by the owner on Apr 28, 2022. It is now read-only.

Inconsistency: A captcha reload on an incorrect submit has default values #5

Closed
tinderboxmedia opened this issue Jul 5, 2021 · 5 comments
Labels
enhancement New feature or request

Comments

@tinderboxmedia
Copy link

If an individual fails to solve the captcha and if another attempt is allowed, the captcha will refresh but it will override variables such as timeout, digits_only and add_noice. This feels like an inconsistency in the logic as a refresh should give a new captcha but with all the user declared variables and values. If the function is declared to not add_noice or to be digits_only, a refresh should not change this behaviour, unless declared otherwise.

To fix this inconsistency the captcha refresh should either follow the user declared variables and values, or one should be able to allow this override to happen or not.

@SwissCorePy
Copy link
Owner

the idea behind this is the possibility to give the user a harder or easier captcha to solve after x tries. so this is behaviour is intentional

@tinderboxmedia
Copy link
Author

That does make sense actually. Would it be possible though to add an option to override this intentional behaviour?

@SwissCorePy
Copy link
Owner

i could implement a second refresh function that uses the same settings like the previous one. what do you think?

@tinderboxmedia
Copy link
Author

That would be perfect! Thanks.

@SwissCorePy SwissCorePy added the enhancement New feature or request label Jul 5, 2021
@SwissCorePy
Copy link
Owner

I updated the package. in version 1.03 refresh_captcha uses the previous captcha settings if not set again.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants