Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: remove anon-id cookies creation #584

Merged
merged 2 commits into from Aug 19, 2022
Merged

Conversation

lorenzo-cavazzi
Copy link
Member

Anon-id cookies will be set by the UI server

/deploy renku-ui=1601-anon-id #persist

@lorenzo-cavazzi lorenzo-cavazzi requested a review from a team as a code owner August 16, 2022 14:25
@lorenzo-cavazzi lorenzo-cavazzi temporarily deployed to renku-ci-gw-584 August 16, 2022 14:26 Inactive
@lorenzo-cavazzi lorenzo-cavazzi marked this pull request as draft August 16, 2022 14:28
@RenkuBot
Copy link
Contributor

You can access the deployment of this PR at https://renku-ci-gw-584.dev.renku.ch

@lorenzo-cavazzi lorenzo-cavazzi temporarily deployed to renku-ci-gw-584 August 16, 2022 14:32 Inactive
@lorenzo-cavazzi lorenzo-cavazzi temporarily deployed to renku-ci-gw-584 August 16, 2022 15:17 Inactive
@lorenzo-cavazzi lorenzo-cavazzi marked this pull request as ready for review August 18, 2022 13:30
Copy link
Contributor

@ciyer ciyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm sure everyone is glad to have this functionality out of the gateway!

@lorenzo-cavazzi lorenzo-cavazzi merged commit 122eb05 into master Aug 19, 2022
@lorenzo-cavazzi lorenzo-cavazzi deleted the ui1602-anon-id branch August 19, 2022 09:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants