feat: add new /api/kg/webhooks path #639
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
You can access the deployment of this PR at https://renku-ci-gw-639.dev.renku.ch |
lorenzo-cavazzi
force-pushed
the
add-webhooks-path
branch
from
03e39ec
to
1199873
Compare
lorenzo-cavazzi
approved these changes
May 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
/deploy #persist
As discussed with @lorenzo-cavazzi it will be nice to have all requests going to the KG and its components to go through the
/kgroute.Currently the
/api/projectspath leads to Gitlab most of the time except in a few specific cases when it goes to the kg. With the addition of the new path this is not the case anymore. This makes the pathing and logic easier to follow and it reduces the changes of errors.