Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Cache hook validation results #1554

Merged
merged 18 commits into from Jun 15, 2023
Merged

feat: Cache hook validation results #1554

merged 18 commits into from Jun 15, 2023

Conversation

eikek
Copy link
Member

@eikek eikek commented Jun 13, 2023 •
edited by jachro

The hook validation result is cached for 10 seconds.

/deploy #persist

closes #1537

eikek added 3 commits June 8, 2023 17:57
@eikek
WIP: add cache for hook validation
48b8e39
@eikek
WIP: add some features
2bce12b 
missing: invalidate on get, timer for periodically removing stuff
@eikek
WIP: implementation and tests
6aee0fc
@eikek eikek changed the title 1537 cache hook validation feat: Cache hook validation results Jun 13, 2023
@eikek eikek temporarily deployed to renku-ci-gr-1554 June 15, 2023 08:14 — with GitHub Actions Inactive
@RenkuBot
Copy link
Collaborator

You can access the deployment of this PR at https://renku-ci-gr-1554.dev.renku.ch

@eikek eikek marked this pull request as ready for review June 15, 2023 09:06
@eikek eikek requested a review from a team as a code owner June 15, 2023 09:06
@eikek eikek temporarily deployed to renku-ci-gr-1554 June 15, 2023 10:08 — with GitHub Actions Inactive
@eikek eikek temporarily deployed to renku-ci-gr-1554 June 15, 2023 11:34 — with GitHub Actions Inactive
@jachro jachro temporarily deployed to renku-ci-gr-1554 June 15, 2023 11:56 — with GitHub Actions Inactive
jachro
jachro approved these changes Jun 15, 2023
View reviewed changes
Copy link
Contributor

@jachro jachro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks really cool! Cannot wait to see it in action

@eikek eikek deployed to renku-ci-gr-1554 June 15, 2023 13:22 — with GitHub Actions Active
@eikek eikek merged commit a70eba4 into development Jun 15, 2023
13 checks passed
@eikek eikek deleted the 1537-cache-hook-validation branch June 15, 2023 14:47
@jachro jachro mentioned this pull request Jun 29, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jachro jachro jachro approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Try to make Project Status API cache hook validation checks
3 participants
@eikek @RenkuBot @jachro