Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: inject new set of tokens when the session is resumed #1734

Merged
merged 3 commits into from Dec 14, 2023

Conversation

olevski
Copy link
Member

@olevski olevski commented Dec 14, 2023

This fixes the issues we have had with expiring Gitlab access tokens.

/deploy renku=fix-gitlab-token-in-sessions

@olevski olevski requested a review from a team as a code owner December 14, 2023 09:58
@RenkuBot
Copy link
Contributor

You can access the deployment of this PR at https://renku-ci-nb-1734.dev.renku.ch

renku_notebooks/api/classes/k8s_client.py Outdated Show resolved Hide resolved
renku_notebooks/api/classes/k8s_client.py Outdated Show resolved Hide resolved
m-alisafaee
m-alisafaee previously approved these changes Dec 14, 2023
Copy link
Contributor

@m-alisafaee m-alisafaee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@olevski olevski merged commit 6909869 into master Dec 14, 2023
15 checks passed
@olevski olevski deleted the fix-gitlab-tokens branch December 14, 2023 14:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants