Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

validate server_options #71

Closed
rokroskar opened this issue Oct 18, 2018 · 0 comments · Fixed by #529
Closed

validate server_options #71

rokroskar opened this issue Oct 18, 2018 · 0 comments · Fixed by #529
Assignees
@olevski
Labels
enhancement New feature or request
Milestone
sprint-2021-01-29

Comments

@rokroskar
Copy link
Member

rokroskar commented Oct 18, 2018 •
edited by sdsc-org
Loading

The server_options need validation in several places:

  • in the values.yaml that the admin passes on deployment
  • in the service code where the request withserverOptions in the body is processed

It's not obvious what the validation should consist of, however.

  1. Enforce only a specific set of server options, e.g. resources.cpu_request, resources.mem_request etc.
  2. Make sure that the serverOptions that are passed in through the request conform to the types specified in the values.yaml.
  3. ?

This validation was left as a todo from pr #68.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@olevski olevski

Labels
enhancement New feature or request
Projects
None yet
Milestone
sprint-2021-01-29
Development

Successfully merging a pull request may close this issue.

feat: validate server options SwissDataScienceCenter/renku-notebooks
3 participants
@rokroskar @ableuler @olevski