Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(app): when a gitlab project does not exist log a warning not error #763

Merged
merged 1 commit into from
Oct 4, 2021

Conversation

olevski
Copy link
Member

@olevski olevski commented Sep 27, 2021

There can be many occasions when a gitlab project is found to not exist when the code expects it to exist.

In all such cases flasks logger is used to post an error. However this is then also picked up by sentry and it causes unnecessary notifications.

I was able to reproduce this error by:

  • creating a project
  • launching a sessions
  • deleting the project in gitlab while remaining on the sessions page in the ui
  • any request to list the sessions after this causes the error to show up in the logs and in sentry

I can confirm that even though the gitlab project is deleted but the session still exists the notebooks service properly lists the session and does not crash or return code 500. But there is an error message in the logs every time a request to the API is sent.

@olevski olevski merged commit ce7af2a into master Oct 4, 2021
@olevski olevski deleted the fix-do-not-log-error-when-project-does-not-exist branch October 4, 2021 07:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants