fix(service): push to protected branches #1614
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Panaetius
reviewed
Oct 16, 2020
| if origin.refs and repo.active_branch in origin.refs: | ||
| origin.fetch() | ||
| origin.pull(repo.active_branch) | ||
|
|
||
| origin.push(repo.active_branch) | ||
| result = origin.push(repo.active_branch) | ||
| if result and "[remote rejected] (pre-receive hook declined)" in result[0].summary: |
There was a problem hiding this comment.
It's a bit weird that git itself returns something like ! [remote rejected] master -> master (protected branch hook declined) but GitPython returns [remote rejected] (pre-receive hook declined) without the branch->branch part.
I wonder if there's a case where GitPython might also return the longer message?
There was a problem hiding this comment.
I think GitPython only captures the last part of the message. It's also very strange that they don't raise exception on git error anymore but return the InfoResult object. 🤷
Panaetius
approved these changes
Oct 16, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.