Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(svc): add endpoints for renku config #1834

Merged
merged 8 commits into from Feb 10, 2021
Merged

feat(svc): add endpoints for renku config #1834

merged 8 commits into from Feb 10, 2021

Conversation

Panaetius
Copy link
Member

@Panaetius Panaetius commented Jan 13, 2021 •
edited

closes #1819
closes #1783

/deploy

@Panaetius Panaetius requested a review from a team as a code owner January 13, 2021 16:35
@Panaetius Panaetius temporarily deployed to renku-ci-rp-1834 February 4, 2021 08:58 Inactive
@RenkuBot
Copy link
Contributor

RenkuBot commented Feb 4, 2021

You can access the deployment of this PR at https://renku-ci-rp-1834.dev.renku.ch

jsam
jsam reviewed Feb 4, 2021
View reviewed changes
renku/cli/utils/click.py Outdated Show resolved Hide resolved
jsam
jsam reviewed Feb 4, 2021
View reviewed changes
renku/cli/utils/click.py Outdated Show resolved Hide resolved
jsam
jsam reviewed Feb 4, 2021
View reviewed changes
renku/service/views/config.py Outdated Show resolved Hide resolved
jsam
jsam reviewed Feb 4, 2021
View reviewed changes
Copy link
Contributor

@jsam jsam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Look's amazing! Thank you very much.

I just posted a couple of questions before we merge. 👍

@Panaetius Panaetius temporarily deployed to renku-ci-rp-1834 February 4, 2021 14:50 Inactive
@Panaetius Panaetius requested a review from jsam February 5, 2021 07:39
@Panaetius Panaetius temporarily deployed to renku-ci-rp-1834 February 5, 2021 08:37 Inactive
@jsam
Copy link
Contributor

jsam commented Feb 9, 2021

Thanks, look's great! Let me know once you rebase it so we can merge it! 🚀

@Panaetius Panaetius temporarily deployed to renku-ci-rp-1834 February 9, 2021 16:05 Inactive
@Panaetius Panaetius deployed to renku-ci-rp-1834 February 9, 2021 16:47 Active
jsam
jsam approved these changes Feb 10, 2021
View reviewed changes
Copy link
Contributor

@jsam jsam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you. 🚀

@Panaetius Panaetius merged commit c09ca6b into master Feb 10, 2021
@Panaetius Panaetius deleted the 1819-renku-config-endpoint branch February 10, 2021 11:18
@lorenzo-cavazzi lorenzo-cavazzi mentioned this pull request Apr 12, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jsam jsam jsam approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Expose renku config command through core service renku config set committing files other than renku.ini
3 participants
@Panaetius @RenkuBot @jsam