feat(service): improve formatting for migrationscheck response

[Panaetius]

closes #2048
/deploy extra-values=core.debug=true

[RenkuBot]

You can access the deployment of this PR at https://renku-ci-rp-2122.dev.renku.ch

[m-alisafaee]

Thanks Ralf! This looks pretty good.

[m-alisafaee]

Isn't core_renku_version the same as dockerfile_renku_status.latest_renku_version? Is there a reason to have redundant info here? Also project_renku_version comes from the commit agent which should be newer than dockerfile_renku_status.dockerfile_renku_version; do we need both of them here?

[m-alisafaee]

API version is currently done like /v0.9/ but according to the RFC it should be like /0.9/.

[Panaetius]

Isn't core_renku_version the same as dockerfile_renku_status.latest_renku_version? Is there a reason to have redundant info here? Also project_renku_version comes from the commit agent which should be newer than dockerfile_renku_status.dockerfile_renku_version; do we need both of them here?

Yes it is duplicate, UI requested core_renku_version and dockerfile_renku_status.latest_renku_version like this. I don't think it matters having it duplicated and if this makes implementing logic on there side easier, why not.

dockerfile_renku_status.dockerfile_renku_version is relevant for updating the Dockerfile (Can also be None). project_renku_version is irrelevant imo, maybe nice to have to present to a user. But if a user manually modifies Dockerfile, they could be disparate (And the project probably broken). I think the UI just uses project_renku_version to say "Updating from 0.16.2 to 1.0.0" even though what is actually done is updating from 8 to 9, but users don't know what "8" or "9" means.

From our point of view it doesn't matter but I think it's useful for the UI to show to users (to hide some complexity).