Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(service): handle uploaded images in datasets.edit #2243

Merged
merged 4 commits into from Aug 16, 2021

Conversation

m-alisafaee
Copy link
Contributor

Fixes #2240

@m-alisafaee m-alisafaee marked this pull request as ready for review August 5, 2021 18:07
@m-alisafaee m-alisafaee requested a review from a team as a code owner August 5, 2021 18:07
@m-alisafaee m-alisafaee force-pushed the 2240-edit-dataset-image-in-service branch 2 times, most recently from 20a6887 to 47a2754 Compare August 6, 2021 06:36
Copy link
Member

@Panaetius Panaetius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nicely done with the new fixture, much cleaner.

renku/service/controllers/datasets_edit.py Outdated Show resolved Hide resolved
@m-alisafaee m-alisafaee force-pushed the 2240-edit-dataset-image-in-service branch from 47a2754 to 96cef40 Compare August 10, 2021 10:39
Panaetius
Panaetius previously approved these changes Aug 10, 2021
@Panaetius Panaetius enabled auto-merge (squash) August 16, 2021 15:08
@Panaetius Panaetius merged commit 48adb54 into master Aug 16, 2021
@Panaetius Panaetius deleted the 2240-edit-dataset-image-in-service branch August 16, 2021 16:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

datasets.edit endpoint doesn't support uploaded images
2 participants