feat(core): make rerun work with new storage #2319
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
m-alisafaee
force-pushed
the
2258-renku-rerun
branch
from
b7d0c43
to
b19e016
Compare
Panaetius
requested changes
Sep 13, 2021
| def _get_activities(paths: List[str], sources: List[str], activity_gateway: IActivityGateway): | ||
| all_activities = defaultdict(set) | ||
|
|
||
| def include_newest_activity(activity): |
There was a problem hiding this comment.
This is a duplicate of the one used in update, would make sense to unify them
There was a problem hiding this comment.
I've added a more general utility function and used it here. There is still a duplicated line but I believe it's more readable and re-usable this way.
m-alisafaee
force-pushed
the
2257-new-renku-update
branch
7 times, most recently
from
7279445
to
f57ccb2
Compare
m-alisafaee
force-pushed
the
2258-renku-rerun
branch
2 times, most recently
from
b27701c
to
2aa8abd
Compare
m-alisafaee
force-pushed
the
2258-renku-rerun
branch
from
2aa8abd
to
79f8757
Compare
Panaetius
approved these changes
Sep 15, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Reimplementation of the
renku run <paths>using the new persistent layer. Support--fromflag to start execution from a specific path. Returns 1 if no workflow is re-executed.Followup story: #2323
Fixes #2258