feat(cli): add a flag to fail on migration errors #2349
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
m-alisafaee
force-pushed
the
2337-fail-migrations-on-errors
branch
2 times, most recently
from
5984e12
to
80ea6cf
Compare
m-alisafaee
force-pushed
the
2337-fail-migrations-on-errors
branch
from
b2e4986
to
f7eb7a7
Compare
m-alisafaee
force-pushed
the
2337-fail-migrations-on-errors
branch
from
f7eb7a7
to
27dde2b
Compare
Panaetius
approved these changes
Sep 22, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add a
--stricthidden flag to allow migrations to fail in tests. Some refactoring. I also removed one of the old projects that we use for migration test; the problem was that datasets' JSON-LD metadata generated by renku is not valid atv0.5.0and this project cannot be migrated without error. We have another project fromv0.5.1that tests the same migration.Fixes #2337