Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(dataset): same_as and DatasetFile id corrections #2356

Merged
merged 3 commits into from Sep 24, 2021
Merged

fix(dataset): same_as and DatasetFile id corrections #2356

merged 3 commits into from Sep 24, 2021

Conversation

m-alisafaee
Copy link
Contributor

Description

Fix id for DatasetFile when removing a file. Fix sameAs during migration by removing dashed from the id.

Fixes #2336

@m-alisafaee m-alisafaee marked this pull request as ready for review September 23, 2021 06:56
@m-alisafaee m-alisafaee requested a review from a team as a code owner September 23, 2021 06:56
@m-alisafaee m-alisafaee marked this pull request as draft September 23, 2021 07:17
@m-alisafaee m-alisafaee marked this pull request as ready for review September 23, 2021 08:22
Panaetius
Panaetius approved these changes Sep 23, 2021
View reviewed changes
Copy link
Member

@Panaetius Panaetius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you

@m-alisafaee m-alisafaee merged commit 3cf7449 into master Sep 24, 2021
@m-alisafaee m-alisafaee deleted the 2336-dataset-migration-fixes branch September 24, 2021 08:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Panaetius Panaetius Panaetius approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Errors when migrating datasets to the new metadata
2 participants
@m-alisafaee @Panaetius