Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(cli): allow CompositePlans to be created based on activities #2385

Merged
merged 2 commits into from Oct 5, 2021

Conversation

Panaetius
Copy link
Member

@Panaetius Panaetius commented Oct 4, 2021

closes #2323

Other than what the linked issue mentions, @rokroskar suggested that we keep rerun as is, supporting reproducibility.

If a user wants to rerun a pipeline with modified parameters, they can now use renku workflow compose --from <input> --to <output> to create a CompositePlan encompassing all the plans that a rerun would execute, with proper values applied (using mappings on the composite). This plan can then be executed using renku workflow execute with modified parameters.

Example Usage:

$ renku run --name run1 -- echo "hello" > output1
$ renku run --name run2 -- cp output1 output2
$ renku workflow compose --to output2 my-composed-workflow
$ renku workflow execute --set 1-parameter-1="Hello World" my-composed-workflow

Note, some refactorings in this PR are the same as in #2372 (namely the sort_activities and get_activities_until_paths ones)

Copy link
Contributor

@vigsterkr vigsterkr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@Panaetius Panaetius merged commit 011f618 into master Oct 5, 2021
@Panaetius Panaetius deleted the 2323-modify-rerun-parameters branch October 5, 2021 07:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow changing parameters/inputs/outputs in the rerun command
2 participants