Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(core): add missing Subject to dataverse export #2420

Merged
merged 1 commit into from Oct 14, 2021
Merged

fix(core): add missing Subject to dataverse export #2420

merged 1 commit into from Oct 14, 2021

Conversation

Panaetius
Copy link
Member

"Subject" is now required in Dataverse exports. This prompts the user on export, defaults to Other

@Panaetius Panaetius requested a review from a team as a code owner October 14, 2021 13:28
m-alisafaee
m-alisafaee approved these changes Oct 14, 2021
View reviewed changes
Copy link
Contributor

@m-alisafaee m-alisafaee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for taking care of this!

@Panaetius Panaetius merged commit 942941c into master Oct 14, 2021
@Panaetius Panaetius deleted the fix-dataverse-subject branch October 14, 2021 16:36
Panaetius added a commit that referenced this pull request Oct 22, 2021
@Panaetius
fix(core): add missing Subject to dataverse export (#2420)
549cdae
Panaetius added a commit that referenced this pull request Nov 17, 2021
@Panaetius
fix(core): add missing Subject to dataverse export (#2420)
2d2fbef
Panaetius added a commit that referenced this pull request Nov 17, 2021
@Panaetius
fix(core): add missing Subject to dataverse export (#2420)
ad7b4c8
Panaetius added a commit that referenced this pull request Nov 17, 2021
@Panaetius
fix(core): add missing Subject to dataverse export (#2420)
55c6fca
Panaetius added a commit that referenced this pull request Nov 17, 2021
@Panaetius
fix(core): add missing Subject to dataverse export (#2420)
9d7d6fc
Panaetius added a commit that referenced this pull request Nov 19, 2021
@Panaetius
feat(service): backport API versioning changes from 1.0.0 release (#2467
e1bc67b 
)

* pin git-lfs on macos to 2.13.3 (#2381)

this is a temporary fix until a proper fix is done for git-lfs v3.0.0
major release

* unlink git-lfs package if installed on macos CI image (#2389)

* fix(core): add missing Subject to dataverse export (#2420)

* bump pyshacl to 0.17.2
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@m-alisafaee m-alisafaee m-alisafaee approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Panaetius @m-alisafaee