Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core): fixes tests and duplicate objects in database, adds asciinema recordings #2427

Merged
merged 5 commits into from Oct 22, 2021

Conversation

Panaetius
Copy link
Member

@Panaetius Panaetius commented Oct 22, 2021

closes #2401
closes #2399

Fixes an issue where objects stored in multiple persistent.Persistent objects get deserialized to individual instances, breaking mappings.

Fixes bug in tests with new git version 2.33.1 (errors if merge strategy for pull is not set)

Updates documentation

Adds asciinema recordings of important commands to docs.

@Panaetius Panaetius requested a review from a team as a code owner October 22, 2021 15:08
@Panaetius Panaetius changed the title 2401 asciinema docs fix(core): fixes tests and duplicate objects in database, adds asciinema recordings Oct 22, 2021
vigsterkr
vigsterkr previously approved these changes Oct 22, 2021
Copy link
Contributor

@vigsterkr vigsterkr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

Copy link
Contributor

@vigsterkr vigsterkr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚢

@Panaetius Panaetius enabled auto-merge (squash) October 22, 2021 16:55
@Panaetius Panaetius merged commit bdce519 into master Oct 22, 2021
@Panaetius Panaetius deleted the 2401-asciinema-docs branch October 22, 2021 17:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add asciinema recordings to documentation Update renku-python documentation for 1.0.0
2 participants