Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core): fix workflow graph generation and CompositePlan view #2436

Merged
merged 6 commits into from Nov 15, 2021

Conversation

Panaetius
Copy link
Member

Changes printing of CompositePlan to show the full path of parameters in parameter links

There was an issue with removing overridden activities in graph generation if the activities shared more than one generation. Only the first generation would be checked and then later on the activity wouldn't be considered as overridden, as it didn't share all generations with the latter activity (since only the first generation was considered)

@Panaetius Panaetius enabled auto-merge (squash) November 5, 2021 08:03
Copy link
Contributor

@m-alisafaee m-alisafaee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@Panaetius Panaetius merged commit 4bb0f08 into master Nov 15, 2021
@Panaetius Panaetius deleted the minor-composite-plan-fixes branch November 15, 2021 18:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants