feat(service): improve migrations_check performance #2443
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Panaetius
changed the base branch from
master
to
2048-finegrained-migration-information
Panaetius
changed the title
Base automatically changed from
2048-finegrained-migration-information
to
master
November 15, 2021 13:43
* initial implementation of workflow loop * Apply suggestions from code review Co-authored-by: Ralf Grubenmann <ralf.grubenmann@sdsc.ethz.ch> * rename loop to iterate subcommand add option to specify mapping via command line for workflow iterate * Apply suggestions from code review Co-authored-by: Ralf Grubenmann <ralf.grubenmann@sdsc.ethz.ch> Co-authored-by: Ralf Grubenmann <ralf.grubenmann@sdsc.ethz.ch>
* fix encoding format for output * add encodingFormat node to shacl_shape for CommandOutput
m-alisafaee
previously approved these changes
Nov 24, 2021
m-alisafaee
reviewed
Nov 24, 2021
m-alisafaee
reviewed
Nov 26, 2021
m-alisafaee
reviewed
Nov 26, 2021
Panaetius
force-pushed
the
2432-optimize-check-migrations
branch
from
beba44a
to
fbcc54e
Compare
m-alisafaee
previously approved these changes
Dec 1, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #2432
the
git archiveapproach only works with git+ssh URLs, and we only get HTTPS in the service (Plus OAUTH2 doesn't work with SSH), so I opted for using the gitlab API to get the files.