Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(core): improve renku status performance #2482

Merged
merged 5 commits into from Dec 1, 2021
Merged

fix(core): improve renku status performance #2482

merged 5 commits into from Dec 1, 2021

Conversation

Panaetius
Copy link
Member

Better early filtering for overridden activities.

Get object-hashes in batches.

@Panaetius Panaetius force-pushed the improve-status-performance branch 5 times, most recently from 4d52560 to 1f27bc2 Compare November 25, 2021 15:53
@Panaetius Panaetius marked this pull request as ready for review November 26, 2021 13:29
@Panaetius Panaetius requested a review from a team as a code owner November 26, 2021 13:29
m-alisafaee
m-alisafaee requested changes Nov 26, 2021
View reviewed changes
Copy link
Contributor

@m-alisafaee m-alisafaee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for looking into this! I've made a few comments.

renku/core/metadata/repository.py Outdated Show resolved Hide resolved
renku/core/metadata/repository.py Outdated Show resolved Hide resolved
renku/core/metadata/repository.py Outdated Show resolved Hide resolved
renku/core/metadata/repository.py Outdated Show resolved Hide resolved
renku/core/metadata/repository.py Show resolved Hide resolved
renku/core/metadata/repository.py Outdated Show resolved Hide resolved
renku/core/metadata/repository.py Outdated Show resolved Hide resolved
renku/core/metadata/repository.py Outdated Show resolved Hide resolved
renku/core/utils/metadata.py Outdated Show resolved Hide resolved
renku/core/utils/metadata.py Outdated Show resolved Hide resolved
m-alisafaee
m-alisafaee approved these changes Dec 1, 2021
View reviewed changes
Copy link
Contributor

@m-alisafaee m-alisafaee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you!

@Panaetius Panaetius merged commit 0fadbb2 into master Dec 1, 2021
@Panaetius Panaetius deleted the improve-status-performance branch December 1, 2021 16:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@m-alisafaee m-alisafaee m-alisafaee approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Panaetius @m-alisafaee