Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(service): add project.lock_status endpoint #2531

Merged
merged 7 commits into from Dec 21, 2021

Conversation

m-alisafaee
Copy link
Contributor

@m-alisafaee m-alisafaee commented Dec 15, 2021

Description

  • Adds a project.lock_status endpoint which returns whether a project is locked for writing or not.
  • Make API version 1.0 the default version.

NOTE: When a project is not in the cache or the project_id/git_url is not found, this will NOT raise an error and just returns false (i.e. not locked).

Fixes #2507
Fixes #2532

/deploy renku-ui=1.0-next

@m-alisafaee m-alisafaee temporarily deployed to renku-ci-rp-2531 December 15, 2021 19:06 Inactive
@RenkuBot
Copy link
Contributor

You can access the deployment of this PR at https://renku-ci-rp-2531.dev.renku.ch

@m-alisafaee m-alisafaee temporarily deployed to renku-ci-rp-2531 December 16, 2021 10:19 Inactive
@m-alisafaee m-alisafaee temporarily deployed to renku-ci-rp-2531 December 16, 2021 12:02 Inactive
@m-alisafaee m-alisafaee temporarily deployed to renku-ci-rp-2531 December 17, 2021 11:28 Inactive
@lorenzo-cavazzi lorenzo-cavazzi temporarily deployed to renku-ci-rp-2531 December 17, 2021 14:24 Inactive
Copy link
Member

@lorenzo-cavazzi lorenzo-cavazzi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, it works well from the client side 👍

@m-alisafaee m-alisafaee marked this pull request as ready for review December 20, 2021 09:56
@m-alisafaee m-alisafaee requested a review from a team as a code owner December 20, 2021 09:56
@m-alisafaee m-alisafaee temporarily deployed to renku-ci-rp-2531 December 20, 2021 09:57 Inactive
@vigsterkr vigsterkr deployed to renku-ci-rp-2531 December 21, 2021 07:41 Active
Copy link
Contributor

@vigsterkr vigsterkr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚢

@m-alisafaee m-alisafaee merged commit 082e897 into master Dec 21, 2021
@m-alisafaee m-alisafaee deleted the 2507-lock-status-endpoint branch December 21, 2021 09:37
@lorenzo-cavazzi lorenzo-cavazzi restored the 2507-lock-status-endpoint branch January 6, 2022 15:33
@m-alisafaee m-alisafaee deleted the 2507-lock-status-endpoint branch January 12, 2022 12:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make service API version 1.0 the default add a project.lock_status endpoint to the service
4 participants