Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(service): fix cache.migrate not locking the project #2573

Merged
merged 3 commits into from Jan 17, 2022
Merged

fix(service): fix cache.migrate not locking the project #2573

merged 3 commits into from Jan 17, 2022

Conversation

Panaetius
Copy link
Member

closes #2545

@Panaetius Panaetius requested a review from a team as a code owner January 14, 2022 10:10
m-alisafaee
m-alisafaee previously approved these changes Jan 17, 2022
View reviewed changes
Copy link
Contributor

@m-alisafaee m-alisafaee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you!

@Panaetius Panaetius enabled auto-merge (squash) January 17, 2022 09:00
@Panaetius Panaetius merged commit ed2bcd8 into develop Jan 17, 2022
@Panaetius Panaetius deleted the bugfix/2545-service-migration-lock-project branch January 17, 2022 09:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@m-alisafaee m-alisafaee m-alisafaee approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Locking when migrating a project in the service
2 participants
@Panaetius @m-alisafaee