Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(cli): add explicit parameters to renku run #2583

Merged
merged 9 commits into from Jan 20, 2022
Merged

feat(cli): add explicit parameters to renku run #2583

merged 9 commits into from Jan 20, 2022

Conversation

Panaetius
Copy link
Member

closes #2549

Adds a --param flag to renku run that can be used to explicitly define Parameters.

E.g.

$ renku run touch test
$ renku run --name my-plan --param test -- echo test > output
$ renku workflow show my-plan

Should show a parameter instead of an input.

@Panaetius Panaetius force-pushed the feature/2549-explicit-parameters branch from 5c8e67a to b936173 Compare January 18, 2022 09:44
@Panaetius Panaetius marked this pull request as ready for review January 18, 2022 09:44
@Panaetius Panaetius requested a review from a team as a code owner January 18, 2022 09:44
@Panaetius Panaetius force-pushed the feature/2549-explicit-parameters branch from d95c116 to 576da54 Compare January 18, 2022 10:20
vigsterkr
vigsterkr reviewed Jan 19, 2022
View reviewed changes
Copy link
Contributor

@vigsterkr vigsterkr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, only the parameters..yml part is not clear to me.

renku/core/management/workflow/plan_factory.py Outdated Show resolved Hide resolved
@Panaetius Panaetius marked this pull request as draft January 19, 2022 08:12
@Panaetius Panaetius force-pushed the feature/2549-explicit-parameters branch from 679c326 to a126f99 Compare January 19, 2022 14:36
@Panaetius Panaetius marked this pull request as ready for review January 19, 2022 15:32
vigsterkr
vigsterkr approved these changes Jan 20, 2022
View reviewed changes
Copy link
Contributor

@vigsterkr vigsterkr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@Panaetius Panaetius merged commit 5118774 into develop Jan 20, 2022
@Panaetius Panaetius deleted the feature/2549-explicit-parameters branch January 20, 2022 07:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vigsterkr vigsterkr vigsterkr approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Allow defining explicit parameters in renku run
2 participants
@Panaetius @vigsterkr