Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(core): Execution graph linking of plans #2600

Merged
merged 1 commit into from Jan 24, 2022
Merged

fix(core): Execution graph linking of plans #2600

merged 1 commit into from Jan 24, 2022

Conversation

vigsterkr
Copy link
Contributor

Description

Fixes #2569

(especially) in case of a renku workflow iterate, a CommandParameterBase can share the same ID, but with different parameterization, i.e. different actual_value. Hence Plan::find_parameter should only be true if both of the case matches (not only the ID)

@vigsterkr vigsterkr requested a review from a team as a code owner January 24, 2022 11:18
Panaetius
Panaetius approved these changes Jan 24, 2022
View reviewed changes
Copy link
Member

@Panaetius Panaetius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch! Such a small change for something so difficult to debug/figure out...

Thanks for looking into this!

@vigsterkr vigsterkr merged commit 0528d7c into develop Jan 24, 2022
@vigsterkr vigsterkr deleted the feature/2569-toil-iterate branch January 24, 2022 13:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Panaetius Panaetius Panaetius approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

renku workflow iterate doesn't work with setting intermediate files
2 participants
@vigsterkr @Panaetius