Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(core): use oauth 2.0 device auth grant #2722

Merged
merged 3 commits into from May 24, 2022

Conversation

m-alisafaee
Copy link
Contributor

Description

Replace current custom CLI login flow implemented in the gateway with Device Auth Grant implemented in Keycloak.

Fixes #2636

@m-alisafaee
Copy link
Contributor Author

Note: This PR shouldn't be merged/released before SwissDataScienceCenter/renku#2491 is deployed, or otherwise renku login won't work on the current deployments.

@m-alisafaee m-alisafaee force-pushed the 2636-use-device-auth-grant-for-login branch from c571e8c to 8199b29 Compare May 24, 2022 11:58
Copy link
Member

@Panaetius Panaetius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@m-alisafaee m-alisafaee merged commit eae254e into develop May 24, 2022
@m-alisafaee m-alisafaee deleted the 2636-use-device-auth-grant-for-login branch May 24, 2022 23:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use Device Authorization Grant flow for CLI login
2 participants