Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Referencing a non existing branch in the service APIs doesn't fail #2797

Closed
lorenzo-cavazzi opened this issue Mar 31, 2022 · 0 comments · Fixed by #3534
Closed

Referencing a non existing branch in the service APIs doesn't fail #2797

lorenzo-cavazzi opened this issue Mar 31, 2022 · 0 comments · Fixed by #3534
Assignees
Labels

Comments

@lorenzo-cavazzi
Copy link
Member

Describe the bug
If I try to invoke some of the APIs exposed by the service that allows specifying a branch (E.G. GET /config.show), and I put a non-existing branch name, I get a successful response with the content of a different branch.

To Reproduce
I think the lowest level API to reproduce it is POST /cache.project_clone. But anything containing branch in the parameters leads to the same result.
To reproduce the problem, invoke the API using a valid renku project as git_url and a non-existing branch as branch.

Expected behavior
I would expect the API to fail with a UserRepoReferenceInvalidError error.

Screenshots and/or execution output
Here is an example:
image

image

Run environment (please complete the following information):

  • renku-python version: >= 1.1.4 are affected, as well as develop
    [removed the others, not relevant for the renku-core service]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment