Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(core): add a minimum version check to support breaking forward compatibility #2840

Merged
merged 8 commits into from May 12, 2022
Merged

feat(core): add a minimum version check to support breaking forward compatibility #2840

merged 8 commits into from May 12, 2022

Conversation

Panaetius
Copy link
Member

@Panaetius Panaetius commented Apr 14, 2022 •
edited

closes #2810

can be tested with https://dev.renku.ch/gitlab/ralf.grubenmann/test_minimum_version (has a minimum version requirement if 999.9.9)

@Panaetius Panaetius force-pushed the feature/2810-minimum-renku-version-property branch 6 times, most recently from a3ac463 to 55bffef Compare April 14, 2022 14:21
@Panaetius Panaetius marked this pull request as ready for review April 14, 2022 14:22
@Panaetius Panaetius requested a review from a team as a code owner April 14, 2022 14:22
@Panaetius Panaetius force-pushed the feature/2810-minimum-renku-version-property branch from 55bffef to 839272a Compare April 14, 2022 15:35
@Panaetius Panaetius force-pushed the feature/2810-minimum-renku-version-property branch from 839272a to f2f2613 Compare April 14, 2022 15:36
@Panaetius Panaetius marked this pull request as draft April 19, 2022 06:47
@Panaetius Panaetius force-pushed the feature/2810-minimum-renku-version-property branch from 5cfaa27 to 012e30b Compare April 19, 2022 08:07
@Panaetius Panaetius marked this pull request as ready for review April 19, 2022 13:44
m-alisafaee
m-alisafaee reviewed Apr 27, 2022
View reviewed changes
Copy link
Contributor

@m-alisafaee m-alisafaee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Ralf! Please see my comments.

renku/command/command_builder/database.py Outdated Show resolved Hide resolved
tests/core/commands/test_renku.py Outdated Show resolved Hide resolved
renku/domain_model/project.py Outdated Show resolved Hide resolved
renku/domain_model/project.py Outdated Show resolved Hide resolved
m-alisafaee
m-alisafaee previously approved these changes Apr 29, 2022
View reviewed changes
Copy link
Contributor

@m-alisafaee m-alisafaee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@Panaetius Panaetius enabled auto-merge (squash) April 29, 2022 14:16
@Panaetius Panaetius force-pushed the feature/2810-minimum-renku-version-property branch from 998a0b0 to 239074a Compare May 11, 2022 08:05
@Panaetius Panaetius merged commit 42dc84c into develop May 12, 2022
@Panaetius Panaetius deleted the feature/2810-minimum-renku-version-property branch May 12, 2022 07:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@m-alisafaee m-alisafaee m-alisafaee approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

add minimum_renku_version on project metadata and raise a warning
2 participants
@Panaetius @m-alisafaee