Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(api): project status #2893

Merged
merged 6 commits into from May 12, 2022
Merged

feat(api): project status #2893

merged 6 commits into from May 12, 2022

Conversation

m-alisafaee
Copy link
Contributor

@m-alisafaee m-alisafaee commented May 9, 2022 •
edited

Description

  • Adds a status() method to api.Project
  • Some refactorings/removals

Fixes #2858

@m-alisafaee m-alisafaee force-pushed the 2858-api-project-status branch 2 times, most recently from 6b17133 to 3a4a204 Compare May 10, 2022 10:08
@m-alisafaee m-alisafaee marked this pull request as ready for review May 10, 2022 11:11
@m-alisafaee m-alisafaee requested a review from a team as a code owner May 10, 2022 11:11
Panaetius
Panaetius requested changes May 10, 2022
View reviewed changes
Copy link
Member

@Panaetius Panaetius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! I like the refactored tests, much nicer than runner.run!

renku/core/workflow/run.py Outdated Show resolved Hide resolved
renku/core/workflow/run.py Outdated Show resolved Hide resolved
renku/ui/api/models/project.py Outdated Show resolved Hide resolved
@m-alisafaee m-alisafaee marked this pull request as draft May 11, 2022 12:32
@m-alisafaee m-alisafaee marked this pull request as ready for review May 11, 2022 14:09
@m-alisafaee m-alisafaee marked this pull request as draft May 11, 2022 14:14
@m-alisafaee m-alisafaee marked this pull request as ready for review May 11, 2022 17:57
Panaetius
Panaetius previously approved these changes May 12, 2022
View reviewed changes
Copy link
Member

@Panaetius Panaetius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@m-alisafaee m-alisafaee enabled auto-merge (squash) May 12, 2022 07:45
@m-alisafaee m-alisafaee merged commit 9d49de4 into develop May 12, 2022
@m-alisafaee m-alisafaee deleted the 2858-api-project-status branch May 12, 2022 13:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Panaetius Panaetius Panaetius approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add renku.api Project.status functionality
2 participants
@m-alisafaee @Panaetius