Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(cli): show dataset metadata for tag #2919

Merged
merged 4 commits into from May 24, 2022
Merged

feat(cli): show dataset metadata for tag #2919

merged 4 commits into from May 24, 2022

Conversation

Panaetius
Copy link
Member

closes #2902

@Panaetius Panaetius requested a review from a team as a code owner May 20, 2022 14:19
@Panaetius Panaetius force-pushed the feature/2902-dataset-show-tag branch from 7cb6fec to 01c46a4 Compare May 20, 2022 14:20
@Panaetius Panaetius force-pushed the feature/2902-dataset-show-tag branch from 01c46a4 to e0cafb7 Compare May 24, 2022 06:44
m-alisafaee
m-alisafaee reviewed May 24, 2022
View reviewed changes
Copy link
Contributor

@m-alisafaee m-alisafaee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Ralf, looks good! Just some minor comments.

renku/core/dataset/dataset.py Show resolved Hide resolved
tests/cli/test_datasets.py Show resolved Hide resolved
m-alisafaee
m-alisafaee approved these changes May 24, 2022
View reviewed changes
Copy link
Contributor

@m-alisafaee m-alisafaee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@Panaetius Panaetius enabled auto-merge (squash) May 24, 2022 16:57
@Panaetius Panaetius merged commit 713b4a4 into develop May 24, 2022
@Panaetius Panaetius deleted the feature/2902-dataset-show-tag branch May 24, 2022 20:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@m-alisafaee m-alisafaee m-alisafaee approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add --tag option to renku dataset show
2 participants
@Panaetius @m-alisafaee