New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(dataset): import dataset at specific tags #2926
Conversation
e5ee508
to
104b0d5
Compare
d58bd5d
to
7c7b5a3
Compare
7c7b5a3
to
7feff9d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for removing attrs!
I think the whole dataset add/import logic has grown a bit organically over the years, and it's become a bit hard to follow in parts, with many edge cases and different conditions. I wonder if at some point we should refactor it, with dedicated classes for different behaviors. Similar to how we reworked the template logic.
That might make it easier to understand and maintain.
Totally agreed! I believe a good time for this is when we want to implement new dataset features like adding pointers from S3. |
14c5aa6
to
c397fe2
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you
Description
Allows specifying a dataset tag when importing a Renku dataset. It then imports the specified version (files and metadata) instead of the latest version.
Fixes #2904
Fixes #2910