fix: prevent deletion of plans that are still used in composite plans #2993
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Panaetius
changed the title
Panaetius
force-pushed
the
bugfix/2968-fix-workflow-remove-composite
branch
from
8ea2e7c
to
cf8c4c8
Compare
m-alisafaee
reviewed
Jul 7, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #2968
I didn't implement the
--recursive, for that we'd have to recursively get containing plans (as a composite can contain a composite), warn the user about all of them and then remove them, which I think has a high chance of doing more than a user wants and makes the command more complicated, plus probably very rarely needed. We can add it if there is actual user need for it in the future