feat(core): allow per dataset data directory #3027
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Panaetius
force-pushed
the
feature/2977-datadir-per-dataset
branch
from
e172452
to
5d7c914
Compare
olevski
previously approved these changes
Jul 19, 2022
m-alisafaee
requested changes
Jul 19, 2022
|
We should also display dataset's data dir in |
Panaetius
force-pushed
the
feature/2977-datadir-per-dataset
branch
from
522496f
to
cbd03fe
Compare
Panaetius
force-pushed
the
feature/2977-datadir-per-dataset
branch
from
a539df9
to
233c747
Compare
|
Don't merge until a new release is made |
m-alisafaee
previously approved these changes
Jul 20, 2022
I was worried that might be the case. I think last time when we set it to 1.2.0, we were already on 1.2.4 or something like that. Maybe we should change the minimum version to be exclusive, i.e. 1.5.0 would mean "Version must be higher than 1.5.0", and then 1.5.0.dev25+gd4dfa1ce might pass. Though I doubt it. |
Panaetius
force-pushed
the
feature/2977-datadir-per-dataset
branch
3 times, most recently
from
abdae49
to
06de6b6
Compare
Panaetius
force-pushed
the
feature/2977-datadir-per-dataset
branch
from
06de6b6
to
fec519a
Compare
Panaetius
force-pushed
the
feature/2977-datadir-per-dataset
branch
from
2b87168
to
e04d40f
Compare
Panaetius
force-pushed
the
feature/2977-datadir-per-dataset
branch
from
1e144d2
to
8761c3c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #2977
Adds a
--datadiroption torenku dataset create,renku dataset add --createandrenku dataset import)