feat(workflow): add dot output on workflow visualize #3032
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Fixes also a bug when providing wrong columns fix #2376
Panaetius
requested changes
Jul 21, 2022
| .. code-block:: console | ||
|
|
||
| $ renku workflow visualize --format dot <path> | ||
|
|
There was a problem hiding this comment.
Maybe write a sentence that this would print dot format, which could be accepted by the dot command
tests/cli/test_workflow.py
Outdated
Comment on lines
926
to
935
| '"Y" -> "bash -c \\"cat X Y | tee R S\\"";' in result.output | ||
| '"X" -> "bash -c \\"cat X Y | tee R S\\"";' in result.output | ||
| '"bash -c \\"cat X Y | tee R S\\"" -> "R";' in result.output | ||
| '"bash -c \\"cat X Y | tee R S\\"" -> "S";' in result.output | ||
| 4 == result.output.count('"bash -c \\"cat X Y | tee R S\\"') | ||
|
|
||
| 1 == result.output.count('"echo other > H" -> "H"') | ||
| 1 == result.output.count('-> "H"') | ||
| 0 == result.output.count('"H" -->') | ||
| 1 == result.output.count('"H"') |
There was a problem hiding this comment.
All of these statements need an assert in front of them.
lorenzo-cavazzi
force-pushed
the
2376c-workflow-dot
branch
from
1def087
to
531869c
Compare
Panaetius
added a commit
that referenced
this pull request
Jul 28, 2022
- Fixes also a bug when providing the wrong columns fix #2376 Co-authored-by: Ralf Grubenmann <ralf.grubenmann@sdsc.ethz.ch>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add a
--formatoption on therenku workflow visualizecommand. The output can now be eitherconsoleordot.Maybe instead of
-iwould it make sense to add an extra format? Something likeconsole,interactive,dot?This also fixes an error when providing non-existing column names
E.G.
renku workflow visualize <path> --columns aaawas triggeringNow it prints
fix #2376