feat(dataset): make dataset providers plugins #3055
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
olevski
force-pushed
the
2971-make-dataset-providers-plugins-alt
branch
2 times, most recently
from
998a29b
to
14f0cf0
Compare
olevski
force-pushed
the
2971-make-dataset-providers-plugins-alt
branch
from
14f0cf0
to
72b4c16
Compare
Panaetius
previously approved these changes
Jul 27, 2022
olevski
force-pushed
the
2971-make-dataset-providers-plugins-alt
branch
from
72ebf6f
to
b37b075
Compare
olevski
force-pushed
the
2971-make-dataset-providers-plugins-alt
branch
from
b37b075
to
3abe065
Compare
Panaetius
previously approved these changes
Jul 27, 2022
|
@Panaetius can I get a re-approve here? There were merge conflicts I had to resolve and that cleared the approval. |
Panaetius
approved these changes
Jul 28, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As I am working through #2971 one of the subtasks is to make the dataset providers plugins.
I isolated the changes for this and thought it would be a good idea to submit this PR separately from the rest.
Also wanted to get a feeling of whether my way of going about this is acceptable. I decided to not try to separate
ProviderApiand the similar importer and exporter abstract classes and try to move some portion of them in the domain_model. But if you think this is necessary then I am happy to do it.For now the plugins simply provide the defintion of a specific ProviderApi. And the provider factory is now using pluggy to list all the providers rather than importing what is only locally available.