fix(cli): allow display of ssh password prompt in clone operations #3075
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Panaetius
force-pushed
the
bugfix/2987-clone-ssh-passphrase-fix
branch
4 times, most recently
from
a5493ee
to
9cb174e
Compare
Panaetius
force-pushed
the
bugfix/2987-clone-ssh-passphrase-fix
branch
from
9cb174e
to
3edc68f
Compare
m-alisafaee
approved these changes
Aug 26, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #2987
We can't use
yaspin/communication.busywith subprocess calls that need a prompt, as yaspin will swallow all shell output while it is running.Also updates communication to allow printing while yaspin is up