fix(service): fix working dir when cloning outside of project_clone view #3164
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
m-alisafaee
reviewed
Oct 12, 2022
Panaetius
force-pushed
the
fix-service-workingdir
branch
from
6ee786c
to
386f029
Compare
Panaetius
force-pushed
the
fix-service-workingdir
branch
from
386f029
to
0d15b36
Compare
m-alisafaee
reviewed
Oct 13, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
the
ProjectClonecontrol is called in the baseRenkuOperationMixin, in which case it wasn't running with the project context and cwd set, which could lead to errors with concurrent requests. This fixes that.