feat(workflow): support for workflow definition files #3176
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
m-alisafaee
force-pushed
the
pitch/workflow-definition-file
branch
4 times, most recently
from
1b17950
to
423aa0c
Compare
m-alisafaee
force-pushed
the
pitch/workflow-definition-file
branch
9 times, most recently
from
dd1a34e
to
0074aef
Compare
m-alisafaee
force-pushed
the
pitch/workflow-definition-file
branch
3 times, most recently
from
bc8c416
to
85264a6
Compare
m-alisafaee
force-pushed
the
pitch/workflow-definition-file
branch
2 times, most recently
from
c7522db
to
79daadd
Compare
m-alisafaee
force-pushed
the
pitch/workflow-definition-file
branch
5 times, most recently
from
a43d41e
to
4ef78fe
Compare
m-alisafaee
force-pushed
the
pitch/workflow-definition-file
branch
3 times, most recently
from
51e6d1d
to
2e11444
Compare
Panaetius
requested changes
Dec 5, 2022
renku/core/util/os.py
Outdated
| @@ -234,7 +241,7 @@ def hash_file(path: Union[Path, str], hash_type: str = "sha256") -> Optional[str | |||
| return hash_file_descriptor(f, hash_type) | |||
|
|
|||
|
|
|||
| def hash_str(content: str, hash_type: str = "sha256") -> str: | |||
| def hash_string(content: str, hash_type: str = "md5") -> str: | |||
There was a problem hiding this comment.
This isn't actually used anywhere? The function above it uses sha256 as well, and the docstring of this function still says sha256.
Was there a reason to change this?
There was a problem hiding this comment.
I removed this function since we have it in the git history.
md5 is a bit faster than sha256 and since this is used just for hashing (and not cryptography) and we might use it a lot, I've replaced the hash function.
There was a problem hiding this comment.
but wouldn't that cause issues with existing hashes?
There was a problem hiding this comment.
Right. I've used md5 for new hash functions and this is the only old one that I've replaced. It's not used anywhere so no harm done.
Panaetius
reviewed
Dec 6, 2022
m-alisafaee
force-pushed
the
pitch/workflow-definition-file
branch
from
bccfb7d
to
adb7445
Compare
Panaetius
requested changes
Dec 16, 2022
m-alisafaee
force-pushed
the
pitch/workflow-definition-file
branch
2 times, most recently
from
92341b1
to
e6f572f
Compare
m-alisafaee
force-pushed
the
pitch/workflow-definition-file
branch
2 times, most recently
from
bafb439
to
fbe852a
Compare
m-alisafaee
force-pushed
the
pitch/workflow-definition-file
branch
from
fbe852a
to
03892e9
Compare
Panaetius
approved these changes
Dec 19, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Workflow definition file pitch:
renku run workflow-file.ymlandrenku workflow show workflow-file.yml.Every existing file that has a
.ymlor.yamlextension and is not executable is considered to be a workflow file. Also, valid YAML files that contain a dictionary are considered to be a workflow file. We can also force running a workflow file by passing the--fileflag.Some Decisions
workflow-file.pre-processing). It is calledqualified name. This is done to make sure that workflow file steps will have a unique name which is required for the Renku workflow machinery to function correctly.renku statusworks as intended.renku statusshows if a workflow file has changed and its generation. Note thatrenku updatedoesn't re-run workflow files. Users need to run the workflow file to bring its generations up to date.WorkflowFileCompositePlan; We stored the plan with all steps. We can later find out if a subset of steps were executed by looking at the number of activities that are stored in theWorkflowFileActivityCollection.Demo Project
A demo project is available at https://gitlab.dev.renku.ch/mohammad.alisafaee/workflow-file-demo.git.