Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

return ssh status in migrations_check #3293

Closed
Panaetius opened this issue Jan 24, 2023 · 2 comments · Fixed by #3318
Closed

return ssh status in migrations_check #3293

Panaetius opened this issue Jan 24, 2023 · 2 comments · Fixed by #3318

Comments

@Panaetius
Copy link
Member

Add support in /cache.migrations_check endpoint on whether a project supports SSH or not.

The basic version of this is just seeing if the template version used is higher than x.

A nice to have would be checking if port 22 is open/exposed in a session, maybe using https://github.com/NVIDIA/container-canary . Or checking that an image is based on an appropriate base image.

@Panaetius
Copy link
Member Author

Panaetius commented Jan 24, 2023

This could also mean reviving SwissDataScienceCenter/amalthea#239 so you'd get an error when starting a session with SSH enabled but it doesn't support SSH

@Panaetius
Copy link
Member Author

An easy solution would be to just extend the template manifest.yaml with a ssh_supported flag that defaults to false and can be set by template authors. We could also have a setting in renku.ini to force enable ssh support for a project.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

1 participant