New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(dataset): external storage backend #3323
Conversation
Pull Request Test Coverage Report for Build 4449216907
💛 - Coveralls |
427f68a
to
4ad7247
Compare
c04bcfd
to
b8538a3
Compare
fc04ebf
to
7aa6786
Compare
bfa20a7
to
e8bec96
Compare
e8bec96
to
5d06c59
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should we separate renku.core.dataset.providers to make it clear what is for storage and what is for just add? It's getting a bit crowded in there.
And I'm a bit torn on the internal naming going from external
to cloud
, since it's not all cloud-based now. That could easily lead to misunderstandings. I like external
or remote
more
There are providers that are both storage and for add (S3, Azure, ...). I'm not sure how we can address them. I believe
I changed it to cloud since I've noticed people are using this term. |
Description
Removes external files. Replaces
is_external
withlinked
for linked files. Adds anexternal
storage backend for external files. Store file sizes when adding files to datasets.TODO
2.4.0
since we add new fields to the metadata.Fixes #3284
Fixes #3279