Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(service): return proper errors on migrations check #3334

Merged
merged 20 commits into from May 31, 2023

Conversation

Panaetius
Copy link
Member

closes #2124

@Panaetius Panaetius force-pushed the bugfix/2124-fetch-template-errors branch from 0ffb67b to 6a8f94c Compare February 24, 2023 16:51
@Panaetius Panaetius force-pushed the bugfix/2124-fetch-template-errors branch from 6a8f94c to f710119 Compare February 24, 2023 17:06
@coveralls
Copy link
Collaborator

coveralls commented Feb 24, 2023

Pull Request Test Coverage Report for Build 5134481146

  • 197 of 222 (88.74%) changed or added relevant lines in 24 files are covered.
  • 9 unchanged lines in 6 files lost coverage.
  • Overall coverage increased (+0.06%) to 85.371%

Changes Missing Coverage Covered Lines Changed/Added Lines %
renku/command/checks/githooks.py 3 4 75.0%
renku/command/checks/project.py 3 4 75.0%
renku/command/checks/storage.py 2 3 66.67%
renku/command/checks/workflow.py 7 8 87.5%
renku/command/checks/validate_shacl.py 2 4 50.0%
renku/ui/cli/migrate.py 4 6 66.67%
renku/ui/service/controllers/cache_migrations_check.py 16 18 88.89%
renku/ui/service/serializers/cache.py 25 27 92.59%
renku/command/checks/activities.py 2 5 40.0%
renku/command/checks/datasets.py 8 11 72.73%
Files with Coverage Reduction New Missed Lines %
renku/core/dataset/providers/dataverse.py 1 64.76%
renku/core/workflow/activity.py 1 93.61%
renku/ui/cli/init.py 1 96.9%
renku/ui/cli/service.py 1 68.91%
renku/domain_model/template.py 2 90.68%
renku/ui/service/gateways/gitlab_api_provider.py 3 88.64%
Totals Coverage Status
Change from base Build 5134475966: 0.06%
Covered Lines: 25824
Relevant Lines: 30249

💛 - Coveralls

@Panaetius Panaetius marked this pull request as ready for review February 27, 2023 08:33
@Panaetius Panaetius requested a review from a team as a code owner February 27, 2023 08:33
@Panaetius Panaetius force-pushed the bugfix/2124-fetch-template-errors branch from 9c63b8f to 39dbf8b Compare February 27, 2023 12:00
Copy link
Contributor

@m-alisafaee m-alisafaee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, please see my comments.

renku/command/migrate.py Outdated Show resolved Hide resolved
renku/command/migrate.py Outdated Show resolved Hide resolved
renku/ui/service/views/v1/cache.py Outdated Show resolved Hide resolved
m-alisafaee
m-alisafaee previously approved these changes Mar 8, 2023
m-alisafaee
m-alisafaee previously approved these changes Mar 24, 2023
m-alisafaee
m-alisafaee previously approved these changes Mar 30, 2023
@Panaetius Panaetius force-pushed the bugfix/2124-fetch-template-errors branch from c05ab1a to 580ed9e Compare May 30, 2023 07:13
Copy link
Contributor

@m-alisafaee m-alisafaee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Ralf! It's mainly about docstring updates. Should we use a named-tuple for the return value of doctor checks? It's getting more complicated.

renku/command/checks/activities.py Show resolved Hide resolved
renku/command/checks/datasets.py Show resolved Hide resolved
renku/command/checks/datasets.py Show resolved Hide resolved
renku/command/checks/datasets.py Show resolved Hide resolved
renku/command/checks/githooks.py Show resolved Hide resolved
renku/command/checks/storage.py Show resolved Hide resolved
renku/command/checks/validate_shacl.py Show resolved Hide resolved
renku/command/checks/validate_shacl.py Show resolved Hide resolved
renku/ui/service/gateways/gitlab_api_provider.py Outdated Show resolved Hide resolved
@Panaetius Panaetius enabled auto-merge (squash) May 31, 2023 15:03
@Panaetius Panaetius merged commit 6237dc7 into develop May 31, 2023
28 checks passed
@Panaetius Panaetius deleted the bugfix/2124-fetch-template-errors branch May 31, 2023 17:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Handle Errors in fetch_template properly when checking project status
4 participants