Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(cli): fix starting local session as user without uid 1000 #3341

Merged
merged 3 commits into from Mar 13, 2023
Merged

fix(cli): fix starting local session as user without uid 1000 #3341

merged 3 commits into from Mar 13, 2023

Conversation

Panaetius
Copy link
Member

closes #3321

@Panaetius Panaetius requested a review from a team as a code owner March 2, 2023 15:22
@coveralls
Copy link
Collaborator

coveralls commented Mar 2, 2023 •
edited

Pull Request Test Coverage Report for Build 4402853427

  • 12 of 12 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+86.7%) to 86.678%
Totals Coverage Status
Change from base Build 4385891042: 86.7%
Covered Lines: 25622
Relevant Lines: 29560
💛 - Coveralls

@Panaetius Panaetius force-pushed the bugfix/3321-docker-session-permissions branch from bfc48c1 to 9a76f6b Compare March 3, 2023 08:28
m-alisafaee
m-alisafaee approved these changes Mar 8, 2023
View reviewed changes
Copy link
Contributor

@m-alisafaee m-alisafaee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you!

@Panaetius Panaetius enabled auto-merge (squash) March 10, 2023 13:56
@Panaetius Panaetius merged commit a345346 into develop Mar 13, 2023
27 of 28 checks passed
@Panaetius Panaetius deleted the bugfix/3321-docker-session-permissions branch March 13, 2023 09:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@m-alisafaee m-alisafaee m-alisafaee approved these changes

Assignees
No one assigned
Labels
None yet
Projects
renku-python
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

No write permissions when running renku on an own machine
3 participants
@Panaetius @coveralls @m-alisafaee